import-js/eslint-plugin-import

Support Flow Enums

Open

#2,073 opened on May 14, 2021

View on GitHubContributor guide
 (8 comments) (4 reactions) (0 assignees)JavaScript (1,549 forks)batch import
enhancementflowhelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Babel added support for flow enums here: https://github.com/babel/babel/pull/10344

Currently trying to import an enum results in MyEnum not found in enum-module

They're currently experimental, but should be coming down the pipe. I think it would be pretty trivial to support these, basically add an EnumDeclaration everywhere there is currently a TSEnumDeclaration.

I tried working on a PR for this, but the problem is getting the tests running. EnumDeclaration was added in babel 7.7.0. I was trying to get @babel/eslint-parser going in all the flow-related tests while retaining babel-eslint in other tests, but I kept running into problems.

Contributor guide

Research direction
Add EnumDeclaration handling alongside TSEnumDeclaration in the plugin's import resolution logic. Ensure proper test setup with @babel/eslint parser for Flow related tests.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsbabel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70