import-js/eslint-plugin-import

`no-commonjs` does not appear to work for TypeScript

Open

#1,709 opened on Mar 30, 2020

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,549 forks)batch import
help wantedtypescript

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

I have the following rule enabled:

    // disallow require()
    // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md
    'import/no-commonjs': 'error',

However, in my TypeScript source file, the following line that I expected to error does not:

import Boom = require('boom')

Should it?

Contributor guide

Research direction
Check the no commonjs rule implementation to see if it handles TypeScript's import = require() syntax. Ensure the TypeScript parser is being used and the rule's AST node type detection covers this syntax.
Tech stack
javascripttypescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70