import-js/eslint-plugin-import

[import/newline-after-import] can't Identify require statement when module name is declared by template string

Open

#1,614 opened on Jan 17, 2020

View on GitHubContributor guide
 (1 comment) (2 reactions) (0 assignees)JavaScript (1,549 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

test code:

const assert = require('assert');
const generate = require(`../../src/0118-Pascal's Triangle/generate`);

describe(`#0118-Pascal's Triangle`, () => {});

report error:

Expected 1 empty line after require statement not followed by another require.eslint(import/newline-after-import)

screenshot_2020-01-17_17-11-11

Contributor guide

Research direction
Investigate the `import/newline after import` rule source code to understand how it detects `require` statements and add support for template string literals in the module name.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75