import-js/eslint-plugin-import

False positive: "Multiple default exports" with merged declarations in Typescript

Open

#1,549 opened on Nov 30, 2019

View on GitHubContributor guide
 (0 comments) (5 reactions) (0 assignees)JavaScript (1,549 forks)batch import
bughelp wantedtypescript

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

In Typescript, a class and an interface with the same name are merged into one type. If I want to export that type as default, I have to export default both the class and the interface.

This is incorrectly flagged with Multiple default exports.

Code:

export default interface Foo {
  a: number
}
export default class Foo {}

Actual:

1:1  error  Multiple default exports  import/export
4:1  error  Multiple default exports  import/export

Expected: No linting error.

Versions:

  • Typescript 3.7.2
  • eslint-plugin-import 2.18.2

Contributor guide

Research direction
Inspect the `import/export` rule logic for merged declarations (class and interface with same name) and adjust the detection of multiple default exports to allow declaration merging.
Tech stack
javascripttypescript
Domain
toolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75