import-js/eslint-plugin-import

import/no-duplicates does not catch all duplicates

Open

#1,456 opened on Aug 19, 2019

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,549 forks)batch import
enhancementflowhelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Hi, I came across an example in our codebase where this rule did not catch the duplicate import.

import { ProfilePictureCard, SectionCard } from 'our-component-library';
import type { NativeEventHandler } from 'our-component-library';
// Expected ^^ to trigger error, but it did not.

However this is correctly reported:

import { ProfilePictureCard, SectionCard } from 'our-component-library';
import { type NativeEventHandler } from 'our-component-library';
// ^^ Triggers error.

Contributor guide

Research direction
Examine the implementation of the no duplicates rule to understand why it does not flag separate import type statements. Focus on how the rule collects and compares import specifiers.
Tech stack
javascript
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70