import-js/eslint-plugin-import

Request: the "no-duplicates" rule should support the 'declaration' style when importing flow types

Open

#1,241 opened on Nov 29, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,549 forks)batch import
flowhelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

The "no-duplicates" correctly distinguishes Flow type imports from standard imports.

import {myClass} from './mod'
import type {myType} from './mod'

When using the 'declaration' style this is no longer possible:

import {myClass} from './mod'
import {type myType} from './mod'

Contributor guide

Research direction
Examine the no duplicates rule's handling of type imports and add support for the declaration style import { type ... }.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75