import-js/eslint-plugin-import

Inconsistent import/prefer-default-export with Flow type

Open

#1,164 opened on Aug 23, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,549 forks)batch import
bugflowhelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

The following file is generating a warning that default export should be used.

Prefer default export. (import/prefer-default-export)

/* @flow */

export type AnswerState = {
  foo: string
}

export const answer: AnswerState = {
  foo: ''
}

This one however, is not generating any errors or warnings.

/* @flow */

- export type AnswerState = {
+ type AnswerState = {
  foo: string
}

export const answer: AnswerState = {
  foo: ''
}

+ export type { AnswerState }

Originally posted in #484.

Contributor guide

Research direction
Examine the rule logic for prefer default export to understand why it warns on combined type/value exports but not when types are re exported. Look at how the rule handles Flow type exports and whether it incorrectly treats them as named exports.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLintJavaScriptFlow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60