import-js/eslint-plugin-import

no-cycle: consider deep require calls

Open

#1,056 opened on Mar 30, 2018

View on GitHubContributor guide
 (6 comments) (7 reactions) (1 assignee)JavaScript (1,550 forks)batch import
help wantedsemver-minor

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Just making a note to come back to no-cycle and capture require calls in ExportMap to check for cycles in addition to exploring import statements.

Contributor guide

Research direction
Investigate the ExportMap module in the eslint plugin import source code, understand how it currently tracks import statements, and extend it to also capture require() calls. Then the no cycle rule will automatically use this information to detect cycles involving require.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70