Testinggood first issue
Repository metrics
- Stars
- (4 stars)
- PR merge metrics
- (PR metrics pending)
Description
Description:
As it currently stands, there is a mock client for the Docker API in with the Service tests under docker_test.go - This client shares a sub set of interfaces (only those which we use) to interact with the Docker API, allowing us to more easily mock out those interactions.
This client, and other mocks, should be moved to a more universal mock package we can use for testing across the entire application. There are also other interfaces which need to be fleshed out, notably the ContainerExecAttach interface which requires not only mocking the client but an "interactive" net.Conn interface as well as a *io.Reader as these are returned as part of the HijackedResponse:
type HijackedResponse struct {
Conn net.Conn
Reader *bufio.Reader
}