huggingface/lighteval

[FT] Add tests for `VLLMModel` base methods

Open

#724 opened on May 15, 2025

View on GitHub
 (0 comments) (1 reaction) (1 assignee)Python (514 forks)auto 404
featuregood first issue

Repository metrics

Stars
 (2,496 stars)
PR merge metrics
 (PR metrics pending)

Description

Issue encountered

From @lewtun: in addition to adding integration tests for the vllm backend of lighteval WDYT about prioritising some unit tests for the VLLMModel class methods? That would help catch subtle bugs like this and also protect us a bit from silent, yet breaking changes on the vllm side

Solution/Feature

Add tests for VLLMModel

Contributor guide

Research direction
Look at existing tests in the repository, especially for other model backends, to understand the testing patterns. Then inspect the VLLMModel class methods to write unit tests covering edge cases and potential silent failures.
Tech stack
python
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75