highlightjs/highlight.js

(C++) Incorrect highlight of raw string literals

Closed

#3,585 opened on Jul 16, 2022

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)JavaScript (3,497 forks)batch import
buggood first issuehelp welcomelanguage

Repository metrics

Stars
 (22,960 stars)
PR merge metrics
 (Avg merge 6m) (2 merged PRs in 30d)

Description

Incorrect highlight of raw string literals

A raw string literal will cause any code following it to be highlighted as a string.

屏幕截图(18)

Expected behavior

// just to show the error
vector<string> s({R"(JKhf2n"v; 0>qwv>q " JKhf2n"l0 "v42HHf&g )","4U \"N *+ "});
int other_code;  // just to show the error

Contributor guide

Research direction
Inspect the C++ language grammar in highlight.js to fix the regex for raw string literals. Look at the pattern for `R"(...)"` and ensure it doesn't consume subsequent code.
Tech stack
javascriptcpp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70