hazelcast/hazelcast-eureka

Fix HazelcastClientTestCase

Open

#31 opened on May 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (28 forks)auto 404
good first issue

Repository metrics

Stars
 (33 stars)
PR merge metrics
 (PR metrics pending)

Description

HazelcastClientTestCase test seems to be testing the client, however actually it does not. It should be fixed.

See the comment in the code: https://github.com/hazelcast/hazelcast-eureka/blob/master/src/test/java/com/hazelcast/eureka/one/HazelcastClientTestCase.java#L67

Contributor guide

Research direction
Review the test code to understand what it currently tests and compare with the intended behavior. Update the assertions to verify the client interaction with Eureka, as indicated by the comment on line 67.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80