haskell-nix/hnix-store

Switch derivation test from `-core` to `hspec(-golden)`

Open

#261 opened on Nov 26, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (26 forks)github user discovery
coregood first issue

Repository metrics

Stars
 (99 stars)
PR merge metrics
 (Avg merge 20d 16h) (3 merged PRs in 30d)

Description

It is the only remaining test using tasty and tasty-golden.

There's also a problem with it - it works when run via cabal test core but not via cabal run core as the directory prefix is in the way and it has trouble finding fixture(s). Similar problem was resolved in -nar https://github.com/haskell-nix/hnix-store/blob/master/hnix-store-nar/tests/NarFormat.hs#L171-L187 where it tries both with and without a subdir.

Contributor guide

Research direction
Review the failing test in hnix store core and adapt the approach from hnix store nar's NarFormat.hs to handle both with and without subdirectory prefix.
Tech stack
haskell
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Haskell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75