hashicorp/terraform-provider-aws

[Bug]: aws_backup_selection `selection_tag` and `resources` do not interact as expected

Open

#41,274 opened on Feb 7, 2025

View on GitHub
 (4 comments) (2 reactions) (0 assignees)Go (10,310 forks)github user discovery
bugdocumentationgood first issueservice/backup

Repository metrics

Stars
 (11,045 stars)
PR merge metrics
 (PR metrics pending)

Description

Terraform Core Version

1.7.5

AWS Provider Version

5.86.0

Affected Resource(s)

  • aws_backup_selection

Expected Behavior

Expected Behavior: Backup plan targets S3 buckets with the enable_backup = true tag.1

Actual Behavior

Actual Behavior: Backup plan targets all S3 buckets AND all AWS resources with theenable_backup = true tag.

Terraform Configuration Files

resource "aws_backup_selection" "backup_selection_usw2" {
  provider = aws.usw2

  name         = "my-backup-plan"
  plan_id      = aws_backup_plan.s3_bucket_backup.id
  iam_role_arn = data.aws_iam_role.backup_default_role.arn

  resources = [
    "arn:aws:s3:::*"
  ]

  selection_tag {
    key   = "enable_backup"
    value = "true"
    type  = "STRINGEQUALS"
  }
}

Steps to Reproduce

  1. Apply the given configuration.
  2. Observe the AWS resources added to the AWS Vault of choice.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

Footnotes

  1. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/backup_selection#:~:text=selection_tag%20%2D%20(Optional)%20Tag%2Dbased%20conditions%20used%20to%20specify%20a%20set%20of%20resources%20to%20assign%20to%20a%20backup%20plan. ↩

Contributor guide

Research direction
Inspect the implementation of the aws backup selection resource in the provider, specifically how it builds the CreateBackupSelection API request. Compare with AWS Backup documentation to understand whether resources and selection tag should be combined as a union or intersection. Look at existing unit tests and consider adding a test that reproduces the reported behavior.
Tech stack
awsgo
Domain
backendcloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoTerraformAWS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65