hackmdio/codimd

Should prompt when Imgur upload failed

Open

#460 opened on May 15, 2017

View on GitHubContributor guide
 (1 comment) (1 reaction) (0 assignees)JavaScript (1,038 forks)batch import
Hacktoberfestenhancementminor

Repository metrics

Stars
 (8,949 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently it seems that Imgur has an upload limit that will be triggered when uploading too many images in a short period, Hackmd should prompt user the problem instead of silently dropping it

The pad that reproduces the issue : SITCON 2017 R0 共筆 - HackMD

Contributor guide

Research direction
Look at the image upload code in the repository, likely in a file handling Imgur uploads. Use the error message or response from Imgur to show a notification to the user when the upload limit is reached. Add a try catch block around the upload call and display the error to the UI.
Tech stack
javascriptnodejs
Domain
backendfrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80