h2oai/wave

Add enter handler for textbox

Open

#372 opened on Dec 9, 2020

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Python (279 forks)batch import
featuregood first issueui

Repository metrics

Stars
 (3,677 stars)
PR merge metrics
 (Avg merge 2m) (1 merged PR in 30d)

Description

Add enter handler with similar logic onChange has.

Steps to follow:

  1. Setup project for dev.
  2. Find textbox.tsx.
  3. Implement the feature.
  4. Find textbox.py and showcase your new feature there.
  5. Add needed unit tests in textbox.test.tsx.

Contributor guide

Research direction
Look at the existing onChange handler in textbox.tsx to understand the pattern. Then implement an enter handler following similar logic. Also check textbox.py for the Python side to showcase the feature. Finally, add unit tests in textbox.test.tsx. The issue has an assignee, so check if there is any ongoing work in comments or linked branches.
Tech stack
typescriptreactpython
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with TypeScriptBasic understanding of React componentsHow to run dev setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50