guardicore/monkey

Invalid configurations can be exported in the UI

Open

#3,703 opened on Sep 15, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (752 forks)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

Repository metrics

Stars
 (6,250 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

Contributor guide

Research direction
Investigate the configuration export endpoint in the backend (likely in a Python file handling configuration). Check if there is existing validation logic used during configuration submission and apply it before export. Look at the UI export component to understand the flow. The warning box suggests validation already exists; ensure it's triggered on export as well.
Tech stack
python
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85