guardian/scribe

Add UMD

Open

#83 opened on Mar 24, 2014

View on GitHubContributor guide
 (69 comments) (0 reactions) (0 assignees)JavaScript (265 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (3,516 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This module should work in CommonJS, AMD, and browser globals. Currently it only works for AMD.

Ideally this wrapping would be done as part of the build process.

Re. https://github.com/guardian/scribe/issues/77

Contributor guide

Research direction
Study the current build process in Plumbing.js, then add a UMD wrapper using a tool like grunt umd or by manually wrapping the module. Ensure the module works in CommonJS, AMD, and browser globals.
Tech stack
javascript
Domain
frontendbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70