grpc/grpc-swift-nio-transport

Leaking promise in CommonHTTP2ServerTransport if the transport is never started

Open

#65 opened on Jan 28, 2025

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Swift (36 forks)auto 404
good first issuekind/bugsize/S🔨 semver/patch

Repository metrics

Stars
 (41 stars)
PR merge metrics
 (Avg merge 2d 12h) (4 merged PRs in 30d)

Description

It's possible to leak the promise in CommonHTTP2ServerTransport.swift on line 141 if the transport is created but never started. We should fail the promise on deinit. We can likely reuse something sensible from RuntimeError.

Contributor guide

Research direction
Add a deinit method to CommonHTTP2ServerTransport that fails the pending promise with a RuntimeError to prevent resource leaks.
Tech stack
swift
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75