grafana/pyroscope

util.Logger is NoOpLogger

Open

#2,435 opened on Sep 21, 2023

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C (528 forks)batch import
good first issue

Repository metrics

Stars
 (9,041 stars)
PR merge metrics
 (Avg merge 5d 7h) (62 merged PRs in 30d)

Description

it may hide some logs from us. https://github.com/grafana/pyroscope/pull/2434#discussion_r1332894985 We should rename it or remove

image

### Tasks

Contributor guide

Research direction
Locate the `util.Logger` type in the codebase and examine its implementation. Check all usages to see if it is intentionally a NoOpLogger or if it should be replaced with a real logger. Review the discussion in the linked PR to understand the maintainers' intent. Decide whether to rename it (e.g., to `NoOpLogger`) or remove it entirely, then verify no tests rely on the current name.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70