grafana/pyroscope

[remoteWrite] add more info (like url) when showing errors

Closed

#1,961 opened on May 25, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (528 forks)batch import
good first issue

Repository metrics

Stars
 (9,041 stars)
PR merge metrics
 (Avg merge 5d 7h) (62 merged PRs in 30d)

Description

time="2023-05-25T15:55:10.103354" level=error msg="error happened while ingesting data" file=" remotewrite/queue.go:96" error="response not ok: status code: '404'. body: '404 page not found\n'" key="foo.cpu{}" remote_target=bar

This message would be more helpful if it had the url which is trying to be hit.

Contributor guide

Research direction
The error message is constructed in `remotewrite/queue.go` around line 96. Look for the line that logs the error and modify it to include the URL being requested. Check the HTTP client configuration in the same package to access the request URL. Ensure the URL is available in that scope. No open PRs or conflicting work.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90