golang/go

x/tools/go/analysis/passes/modernize: minmax: suggest deletion of redundant min and max functions

Closed

#75,589 opened on Sep 24, 2025

View on GitHubContributor guide
 (13 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationRefactoringToolshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Proposal Details

I proposal to add a checker to check whether user has impl a max/min instead of builtin max/min. And suggest user to replace with builtin max/min. search

language:go "func min"

in github with get about 142k result in code.

Contributor guide

Research direction
Study existing analyzers in the x/tools/go/analysis/passes/modernize package, especially any minmax related ones. Understand the pattern for writing an analyzer that suggests replacements. Implement a checker that detects user defined min/max functions that can be replaced by built in min/max. Test with Go source code.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70