golang/go

runtime/race: deflake tests

Open

#14,119 opened on Jan 27, 2016

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixcompiler/runtimehelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See https://go-review.googlesource.com/#/c/18968 for context. Race tests run with GOMAXPROCS=1, this makes them more or less reliable. But the ultimate solution is to explicitly annotate tests with required execution order by means of a special "invisible" synchronization primitive (that's what is done for C++ ThreadSanitizer tests). But that would require going over 350 tests.

Contributor guide

Research direction
Examine the referenced CL 18968 for context. Understand how race tests currently run with GOMAXPROCS=1 and why it causes flakiness. Investigate the proposed solution of adding an explicit synchronization primitive to annotate required execution order in tests. Look at existing race tests in the runtime/race directory to identify patterns and implement a simple synchronization helper.
Tech stack
go
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60