ggml-org/llama.cpp

Refactor: Add more typechecking to GGUFWriter.add_key_value

Open

#9,095 opened on Aug 19, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C++ (21,737 forks)batch import
help wantedrefactoring

Repository metrics

Stars
 (124,043 stars)
PR merge metrics
 (Avg merge 6d 8h) (389 merged PRs in 30d)

Description

Background Description

As per this discussion https://github.com/ggerganov/llama.cpp/pull/9074#issuecomment-2296799118 write better error messages in case of wrong types.

FYI: This ticket is free for others to approach

Possible Refactor Approaches

N/A

Contributor guide

Research direction
Examine the GGUFWriter class and its add key value method, then add type validation and improve error messages for wrong types.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65