getredash/redash

Google Spreadsheets worksheet by title cleanup/refactor

Open

#6,409 opened on Aug 31, 2023

View on GitHub
 (5 comments) (3 reactions) (1 assignee)Python (4,236 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (24,845 stars)
PR merge metrics
 (Avg merge 6d 17h) (2 merged PRs in 30d)

Description

In #5334 , I left a few comments about future work on the "fetch worksheet by title" functionality for the google spreadsheets query runner. We should address those, namely:

  • don't use mixed-type variables
  • allow for non-quoted worksheet titles (single word)
  • verify 0/1 indexing of worksheet numbers, and add comment if it differs

Contributor guide

Research direction
Inspect the referenced PR #5334 comments and current code for worksheet by title functionality. Focus on mixed type variables, non quoted title handling, and indexing verification.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60