getredash/redash

Query editor: format query feature breaks syntax of Postgres JSON operator

Open

#5,644 opened on Nov 8, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (4,236 forks)batch import
help wanted

Repository metrics

Stars
 (24,845 stars)
PR merge metrics
 (Avg merge 6d 17h) (2 merged PRs in 30d)

Description

Issue Summary

Query editor: format query feature breaks syntax of Postgres JSON operator

Steps to Reproduce

  1. WHERE keywords @> '[{"keyword":{"id":12345}}]'
  2. Valid according to: https://www.postgresql.org/docs/12/functions-json.html
  3. Gets formatted as keywords @ > '[{"keyword":{"id":12345}}]'
  4. This is invalid syntax because the @ and > have become separated

Technical details:

  • Redash Version: 10.0.0-beta (92e5d78d)

Contributor guide

Research direction
Identify where the SQL formatting logic handles operators and ensure the `@>` operator is not split by spaces.
Tech stack
javascriptsql
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70