getify/monio

Feature: improve ergonomics of identity checks

Open

#26 opened on Apr 25, 2022

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (60 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,127 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In addition to things like IO.is(x) to determine if x is an IO monad instance, we can add Symbol.hasInstance to all the monad definitions so that a more ergonomic x isntanceof IO check will work properly.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/hasInstance

Contributor guide

Research direction
Implement Symbol.hasInstance static method on each monad class (e.g., IO, Maybe, Either) to return true if the argument is an instance of that monad. Follow the pattern from MDN documentation.
Tech stack
javascript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptSymbol.hasInstance
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85