getify/grips

optimization: ?: to ||

Open

#13 opened on Mar 8, 2014

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (22 forks)github user discovery
help wanted

Repository metrics

Stars
 (288 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Minor general optimization (but will happen a lot with grips-css):

m = m ? m : 5

can be optimized to:

m = m || 5

Contributor guide

Research direction
Replace the ternary expression with the logical OR operator for brevity and slight performance gain. Ensure the change passes existing tests.
Tech stack
javascript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85