gbowne1/reactsocialnetwork

[Bug]: Login tests need to be refactored to not use act

Open

#359 opened on Feb 22, 2024

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (60 forks)auto 404
a11ybackendbugcssdevopsenhancementfeaturefrontendgood first issuehelp wantedmedium-complexitymedium-priority

Repository metrics

Stars
 (46 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the Bug

Many of the tests don't pass in /Login/tests/ because they use act

Refactor the test for Login

in particular, refactor login-validation-test.js

Steps to Reproduce

running npm test inside the client

Test Suites: 2 skipped, 4 passed, 4 of 6 total
Tests:       7 skipped, 23 passed, 30 total
Snapshots:   0 total
Time:        35.991 s
Ran all test suites related to changed files.

Watch Usage
 › Press a to run all tests.
 › Press f to run only failed tests.
 › Press q to quit watch mode.
 › Press p to filter by a filename regex pattern.
 › Press t to filter by a test name regex pattern.
 › Press Enter to trigger a test run.

latest run

Screenshots

No response

Which device are you using?

Linux VM

Which operating system are you using?

Lin

Which browser are you using?

Firefox

Additional Context

No response

Contribute

  • I am willing to contribute and submit a pull request

Contributor guide

Research direction
Understand why the test fails due to `act` by reading the test file `login validation test.js`. Check React Testing Library best practices for wrapping updates in `act` and refactor to use `waitFor` or `findBy*` queries instead. Ensure the test remains synchronous and does not require `act` warnings.
Tech stack
javascriptreact
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact Testing Library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60