gajus/react-outside-event

Error on missing onOutsideEvent

Open

#3 opened on May 3, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (9 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (44 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If I wrap an element that does not define an onOutsideEvent method, the following error is thrown

Component does not define "onOutsideEvent" method.

I can fix this by defining an empty method for onOutsideEvent. Would it be better to remove this error or issue a warning instead of an error?

Contributor guide

Research direction
Inspect the HOC source to understand how onOutsideEvent is called and consider changing the error to a warning or removing it.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80