gajus/eslint-plugin-flowtype

require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors

Open

#449 opened on Jun 29, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (152 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,069 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors, since class constructors should never return anything.

Contributor guide

Research direction
Locate the rule implementation for require return type. Add a condition to skip class constructors when annotateUndefined is 'always'. Test that the rule no longer reports errors on constructors.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80