frintjs/frint

frint-react: Move subscription to componentDidMount in `observe` HoC

Open

#417 opened on Apr 11, 2018

View on GitHubContributor guide
 (1 comment) (1 reaction) (0 assignees)JavaScript (37 forks)batch import
help wanted

Repository metrics

Stars
 (746 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

At the moment, it's happening in componentWillMount, which is not recommended.

Contributor guide

Research direction
Locate the observe HoC in the frint react package, identify where componentWillMount is used for subscription, and move that logic to componentDidMount.
Tech stack
javascriptreact
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85