frappe/hrms

Separating Submission of Salary Slips and Creation of Journal Entry in Payroll Entry

Open

#818 opened on Aug 23, 2023

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Python (2,473 forks)auto 404
feature-requestgood first issue

Repository metrics

Stars
 (8,205 stars)
PR merge metrics
 (PR metrics pending)

Description

Information about bug

Currently the Payroll Entry has a button labelled 'Submit Salary Slip' and when click on this it will submit the salary slips and also create a journal entry to book salaries as expenses.

Instead of clicking on 'Submit Salary Slip', user can navigate to salary slips and submit them individually. When this happens the 'Submit Salary Slip' button is not shown and journal entry to book expenses cannot be triggered.

There should be two separate buttons. One for submitting salary slips and other for creating journal entries Screenshot 2023-08-23 at 11 52 10 PM

Module

Payroll

Version

Frappe HR Version: 14.3.2

Installation method

easy-install

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributor guide

Research direction
Examine the existing 'Submit Salary Slip' button handler to identify the code paths for salary slip submission and journal entry creation. Then design separate buttons and corresponding server side methods.
Tech stack
python
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonFrappe Framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75