frappe/hrms

Prompt to confirm document cancel in PWA.

Open

#2,199 opened on Sep 16, 2024

View on GitHub
 (1 comment) (2 reactions) (0 assignees)Python (2,473 forks)auto 404
UXgood first issue

Repository metrics

Stars
 (8,205 stars)
PR merge metrics
 (PR metrics pending)

Description

Information about bug

I was just checking PWA and I opened an existing expense claim. image

There is a cancel button at the bottom to which I got confused with a general Cancel button and pressed it. I realized I had changed the doc status to Cancelled after I got a notification on screen.

It would be better if after pressing cancel, it would take a confirmation like "Are you sure you want to cancel this document ?"

Module

HR, Payroll

Version

erpnext 15.33.2 frappe 15.38.0 frappe_whatsapp v1.0.7 hrms 15.28.3

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributor guide

Research direction
Add a confirmation dialog before the cancel action in the document form. Locate the cancel button handler and implement a confirm prompt.
Tech stack
pythonjavascript
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitFrappe basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90