frappe/frappe

Document: Deferred Insert

Open

#25,777 opened on Apr 2, 2024

View on GitHubContributor guide
 (11 comments) (1 reaction) (0 assignees)Python (2,942 forks)batch import
buggood first issue

Repository metrics

Stars
 (5,938 stars)
PR merge metrics
 (Avg merge 3d 3h) (582 merged PRs in 30d)

Description

  • save_to_db only dumps a maximum of 500 records per queue into the Database hourly.

    Restricting to 500 (arbitrary & very low number) leads to starvation when you're pushing records in higher volumes. We could easily just let the job flush as many records as it can instead?

  • Document creation is reset

    Since doc.insert is used within the deferred_insert API, the creation time is reset during DB insert. Essentially we end up re-writing the original information.

Contributor guide

Research direction
Examine the deferred insert API and the save to db method in the frappe framework. Trace the code path that causes the document creation time to be reset and identify the limit of 500 records per queue. Look for relevant tests and follow the discussion in the issue history.
Tech stack
pythonjavascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGitFrappe Framework Basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65