fossasia/visdom

[feature request]Enable passing markersize as a tensor

Closed

#149 opened on Sep 8, 2017

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Python (1,152 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (9,831 stars)
PR merge metrics
 (Avg merge 9d 12h) (116 merged PRs in 30d)

Description

It would be useful to create plots with points of different markersize. Currently, coloring points differently is supported by specifying the colors in an N, Nx3, or K and Kx3 tensor, N being the number of data points and K the amount of labels:

 - `opts.markersize`  : marker size (`number`; default = `'10'`)
 - `opts.markercolor` : marker color (`np.array`; default = `None`)

However, marker size is just a number.

Contributor guide

Research direction
The issue asks to extend markersize to accept a tensor, similar to markercolor. Examine how markercolor is implemented in the visdom source code (likely in visdom/ init .py or similar). Look for the parsing of opts dict and the validation of markersize. The implementation should allow an array of size N (number of data points) or K (number of classes) to be passed as markersize. Check existing tests and documentation for markercolor as a template. The main challenge is ensuring backward compatibility and proper handling of different array shapes.
Tech stack
pythonnumpy
Domain
datafrontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Python basicsNumPyVisdom API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50