files-community/Files

Bug: Trace to visualize the path in column view don't work if the app theme is different than system theme

Closed

#12,577 opened on Jun 9, 2023

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)C# (2,719 forks)batch import
area - columns viewgood first issue

Repository metrics

Stars
 (43,502 stars)
PR merge metrics
 (Avg merge 11d 15h) (61 merged PRs in 30d)

Description

Description

I can only see the trace when in dark mode image image

It does appear in light mode only very bright colours as background so it's probably only a small coloring issue image

and looking at it with a color picker, it seems like there is actually a small difference between the colours normal background image the selected folder image

Steps To Reproduce

turn the theme to light (even closing and reopening Files preview doesn't solve the issue

Requirements

Change the colour for the previous folders in column view

Files Version

2.4.85.0

Windows Version

Windows 10 (22H2): 19045

Log File

The content however appears when I open the settings and does not seem to be related to changing the theme debug.log

Contributor guide

Research direction
Look into the column view XAML styles, likely in a file like `ColumnView.xaml`, to find the trace path color definitions. Compare the dark and light theme resource dictionaries to identify the missing or incorrect color for light mode. Adjust the color to ensure sufficient contrast; see issue comments for any additional hints.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#XAMLtheme system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80