filecoin-project/go-fil-markets

Use or Remove unused funcs and states

Open

#191 opened on Apr 14, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Go (55 forks)github user discovery
good first issueneeds definition

Repository metrics

Stars
 (77 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In retrievalmarket/types.go, IsTerminalError, IsTerminalStatus, and IsTerminalSuccess are either unused or call only each other.

In storagemarket/types.go, MaxPieceSize, StorageDealProposalNotFound, StorageDealNotFound are unused.

Feel free to add anything else you notice.

Contributor guide

Research direction
Check the specified files for unused functions and remove them. Verify that no other parts of the codebase depend on them.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80