filecoin-project/go-fil-markets

Test cleanup: robustness, table test form

Open

#151 opened on Mar 13, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (1 assignee)Go (55 forks)github user discovery
good first issue

Repository metrics

Stars
 (77 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

@laser noted that the integration tests would be flaky/fail if run in parallel. Oversight on my part, not failing yet, but it highlights some technical debt. This and similar tests would benefit from the table test treatment also.

Contributor guide

Research direction
Review the integration test at retrievalmarket/impl/integration test.go and refactor it into a table driven test to improve parallelism and robustness.
Tech stack
go
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gotesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75