facebookresearch/fmmax

Additional example to study metal grating convergence

Open

#37 opened on Sep 7, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Jupyter Notebook (15 forks)auto 404
good first issue

Repository metrics

Stars
 (149 stars)
PR merge metrics
 (PR metrics pending)

Description

It would be useful to have additional examples which demonstrate the convergence characteristics of the various FMM formulations supported by fmmax. In particular, the crossed metallic grating discussed in https://github.com/facebookresearch/fmmax/discussions/34 could be a good choice. That grating comes from example 3 of Li's paper.

This task could largely be achieved by copying and existing example (e.g. metal grating) and modifying it so that the correct geometry is modeled. The example should also reproduce the figure from Li's paper.

Contributor guide

Research direction
Study the referenced crossed metallic grating from Li's paper and modify the existing metal grating example to model the correct geometry. Reproduce the convergence figure.
Tech stack
python
Domain
None
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35