facebookresearch/fairscale

[cleanup] Remove unused flags and functions in fairscale/benchmarks/pipe.py

Open

#742 opened on Jul 19, 2021

View on GitHubContributor guide
 (4 comments) (0 reactions) (1 assignee)Python (297 forks)auto 404
good first issue

Repository metrics

Stars
 (3,411 stars)
PR merge metrics
 (PR metrics pending)

Description

Cleanup

fairscale/benchmarks/pipe.py has unused flags and functions that need to be cleaned up. The following is a non exhaustive list:

  • Rename MPI_PORT to PG_PORT or something that represents what the constant is used for.
  • Remove eval function since we don't benchmark it.
  • Remove flags "hostname" and other unused flags.

Contributor guide

Research direction
Open the file fairscale/benchmarks/pipe.py, identify the unused flags and functions mentioned, and remove them. Rename MPI PORT to a meaningful name.
Tech stack
pythonpytorch
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90