facebookresearch/ParlAI

ParlaiParser.add_argument should support no_save and no_override

Open

#2,177 opened on Nov 19, 2019

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (2,089 forks)batch import
EnhancementH1 2020Help WantedMinordonotreap

Repository metrics

Stars
 (10,371 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Depends on #2172.

  • If no_save is True, then the option is not saved with the opt.
  • If no_override is True, then the parser will throw a hard error if the value on disk is not what's loaded. This one might have to wait a bit longer.

Contributor guide

Research direction
Study the current ParlaiParser implementation and the referenced issue #2172. Add the 'no save' and 'no override' parameters to the add argument method, ensuring that 'no save' prevents the option from being saved in opt, and 'no override' raises an error if the disk value differs. Write tests to verify the behavior.
Tech stack
python
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70