facebook/relay

Expand PluginInterface support

Open

#2,647 opened on Feb 18, 2019

View on GitHubContributor guide
 (8 comments) (3 reactions) (0 assignees)Rust (1,874 forks)batch import
enhancementhelp wantedwontfix

Repository metrics

Stars
 (18,930 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I just wrote a plugin for scalajs (very rough but works), using the plugin interface and two things would be super nice to support.

  • Extra schema, like in the relayCompilerBin you add directives, it would be nice for a plugin to be able to add custom directives.
  • The getFileFilter function looks for the string graphql, we should be able to override that.

Otherwise, it went well.

Contributor guide

Research direction
Study the Relay compiler plugin interface, specifically how custom directives are added via relayCompilerBin and how getFileFilter is implemented. Look at the PluginInterface trait and identify extension points for custom schema and file filter. Examine existing plugins for patterns.
Tech stack
rustjavascriptgraphql
Domain
toolingbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GraphQLRelayPlugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35