facebook/lexical

Bug: Pasting over linebreaks puts content in different places

Open

#4,815 opened on Jul 24, 2023

View on GitHub
 (8 comments) (10 reactions) (0 assignees)JavaScript (1,349 forks)batch import
contribution-weekcopy+pastegood first issue

Repository metrics

Stars
 (16,523 stars)
PR merge metrics
 (Avg merge 2d 4h) (117 merged PRs in 30d)

Description

When pasting some text with at least two containers/paragraphs on two linebreaks, the text being pasted gets split, the first container (heading) gets on the correct location, and the remaining text gets pasted after the next paragraph.

Lexical version:

Steps To Reproduce

  1. Hit two Shift-Enter inside a paragraph on Lexical's editor
  2. Try pasting a text having two containers, a heading and a paragraph for example

https://github.com/facebook/lexical/assets/5845160/321fe7a4-56b7-488d-a851-7f6d16174514

Lexical playground exports: Playground 2023-07-24T13_10_22.747Z.lexical.zip

The current behavior

The first line of the text being pasted gets to the correct location, and the remaining text gets appended to the end of the paragraph.

The expected behavior

All the text gets inserted to the correct location, preferably keeping the same formatting from where it was copied.

Contributor guide

Research direction
Investigate the clipboard plugin in `packages/lexical clipboard/`. Focus on the `$insertDataTransferForPlainText` or `$insertDataTransferForRichText` functions. Check how pasting into a paragraph with line breaks differs from normal paste. Use the provided playground export to reproduce the bug. Look for recent changes to clipboard handling that might have introduced the regression.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic knowledge of JavaScriptFamiliarity with Lexical editor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60