facebook/fresco

color attribbute in fresco progress

Open

#2,463 opened on Feb 8, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (3,750 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (17,072 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I use a vectodrwable progress that wrap in another drwable and for color of progress i use ?attr/my_attr when I use this progress in other views every things work but when I use it in fressco the atttr color disapear. my vector drawble : <path android:pathData="M23.2,43.5c-11.9,0 -21.7,-9.7 -21.7,-21.7c0,-4.1 1.2,-8.1 3.4,-11.6c0.4,-0.7 1.4,-0.9 2.1,-0.5c0.7,0.4 0.9,1.4 0.5,2.1c-1.9,3 -2.9,6.4 -2.9,10c0,10.3 8.4,18.7 18.7,18.7c0.8,0 1.5,0.7 1.5,1.5C24.7,42.8 24,43.5 23.2,43.5z" android:fillColor="?attr/my_attr"/>

Contributor guide

Research direction
Investigate how Fresco processes vector drawables with theme attributes. The user reports that `?attr/my attr` works in other views but not in Fresco. Examine Fresco's Drawable implementation, particularly how it handles vector drawable inflation and attribute resolution. Look at the `Fresco` and `Drawee` related classes to see if there is support for theme attributes. Also check if there is any existing handling for `?attr` references in Fresco's drawable pipeline. Consider testing with a simple example to reproduce the issue.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Basic understanding of Android drawablesFresco library basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30