ethereum/py-snappy

incorrect comparison

Open

#18 opened on Feb 1, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (9 forks)auto 404
good first issue

Repository metrics

Stars
 (18 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/ethereum/py-snappy/blob/f91082fa1498ed919ef26bd853a4552675c9665a/py_snappy/main.py#L235

your use of cute "C244" constants tripped you up! the comparisons should be to 1 << 8, 1 << 16, and 1 << 24

Contributor guide

Research direction
Inspect the code at the referenced line and correct the comparisons to use 1 << 8, 1 << 16, and 1 << 24.
Tech stack
python
Domain
data
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80