eslint-community/eslint-plugin-promise

promise/catch-or-return should report unhandled Promise.resolve/reject

Open

#55 opened on Jan 23, 2017

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (103 forks)auto 404
enhancementfeedback-soughthelp wanted

Repository metrics

Stars
 (998 stars)
PR merge metrics
 (PR metrics pending)

Description

This innocently looking assignment:

const FAIL = Promise.reject();

causes UnhandledPromiseRejectionWarning if FAIL is not used...

Contributor guide

Research direction
Examine the 'catch or return' rule implementation to understand how it currently detects promise usage and identify why Promise.resolve and Promise.reject are not flagged when unhandled. Investigate if the rule only checks for explicit promise variables or if it needs to track statically known rejected promises.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLintPromises
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65