eslint-community/eslint-plugin-promise

no-callback-in-async-function rule?

Open

#155 opened on Jan 16, 2019

View on GitHubContributor guide
 (2 comments) (2 reactions) (0 assignees)JavaScript (103 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (998 stars)
PR merge metrics
 (PR metrics pending)

Description

Putting callback code inside of async functions like this can lead to a lot of trouble:

async function bigProbs() {
    doSomething(function(err) {
        if (err) throw err; // won't be caught by the parent
        // ...
    })
}

Contributor guide

Research direction
Study the existing rules in eslint plugin promise to understand the pattern. Create a new rule that traverses async functions and reports when a callback function is passed as an argument without proper handling. Write tests and add the rule to the plugin.
Tech stack
javascript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLintGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65