envoyproxy/envoy

Audit YAML parsing code path

Open

#9,039 opened on Nov 15, 2019

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/securityhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The YAML parser we're using are not robust to untrust input, it should only be used to parse local file. We should add some basic limitation in the code base to prevent it happening.

Contributor guide

Research direction
Find all code paths that parse YAML from external sources and add input validation or restrict to trusted local files only.
Tech stack
cpp
Domain
securitybackend
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65