envoyproxy/envoy

fix clang-tidy reported errors on master

Open

#4,863 opened on Oct 26, 2018

View on GitHubContributor guide
 (15 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
beginnerhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: clang-tidy runs against diffs in CI, but it will caught all errors on the lines the PR author touched. Ideally we should make a full clang-tidy run error free.

Contributor guide

Research direction
Set up the envoy build environment, run clang tidy with the project's configuration, and fix each reported error. Check CI logs for examples of errors.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++clang tidyGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60